commit 4ef707f0cd981f5bd95aada43c9e296e6362e0d3
parent 1deb4a8b11a116ef902e8b0ac5fa3d3ec38dc008
Author: Kaleb Luedtke <trenlymc@gmail.com>
Date: Mon, 25 Nov 2024 15:02:28 -0600
Add separate string for successful configuration units (#5002)
<!-- To check a checkbox place an "x" between the brackets. e.g: [x] -->
- [x] I have signed the [Contributor License
Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs).
- [x] This pull request is related to an issue.
- Resolves #4382
This PR adds a new string for configuration units to give additional
clarity between the configuration set being applied successfully and
each individual configuration unit being applied successfully

-----
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5002)
Diffstat:
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/AppInstallerCLICore/Resources.h b/src/AppInstallerCLICore/Resources.h
@@ -106,6 +106,7 @@ namespace AppInstaller::CLI::Resource
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationSettings);
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationStatusWatchArgumentDescription);
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationSuccessfullyApplied);
+ WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationUnitSuccessfullyApplied);
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationSuppressPrologueArgumentDescription);
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationUnexpectedTestResult);
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationUnitAssertHadNegativeResult);
diff --git a/src/AppInstallerCLICore/Workflows/ConfigurationFlow.cpp b/src/AppInstallerCLICore/Workflows/ConfigurationFlow.cpp
@@ -790,7 +790,7 @@ namespace AppInstaller::CLI::Workflow
EndProgress();
if (SUCCEEDED(resultInformation.ResultCode()))
{
- m_context.Reporter.Info() << " "_liv << Resource::String::ConfigurationSuccessfullyApplied << std::endl;
+ m_context.Reporter.Info() << " "_liv << Resource::String::ConfigurationUnitSuccessfullyApplied << std::endl;
}
else
{
diff --git a/src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw b/src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw
@@ -1812,6 +1812,9 @@ Please specify one of them using the --source option to proceed.</value>
<data name="ConfigurationSuccessfullyApplied" xml:space="preserve">
<value>Configuration successfully applied.</value>
</data>
+ <data name="ConfigurationUnitSuccessfullyApplied" xml:space="preserve">
+ <value>Unit successfully applied.</value>
+ </data>
<data name="ConfigurationWaitingOnAnother" xml:space="preserve">
<value>Another configuration is being applied to the system. This configuration will continue as soon as is possible...</value>
</data>