commit 269c3c6bbaf967c9f5a6cb288b79812eec61773d parent 50104825c0cc47ff688c5de8c129d77fc8c75128 Author: Ryan <69221034+ryfu-msft@users.noreply.github.com> Date: Thu, 29 Aug 2024 16:25:45 -0400 Binskim error EnableCriticalCompilerWarnings (#4764) Fixes a binskim error where sfsclient dependencies (curl -> ares) were not getting compiled with a warning level > 3 compiler flag. Added `/W3` to only the release triplets Verified that of WindowsPackageManager.dll no longer shows an error when running with binskim. Diffstat:
8 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/src/VcpkgCustomTriplets/arm-release-static.cmake b/src/VcpkgCustomTriplets/arm-release-static.cmake @@ -1,6 +1,6 @@ set(VCPKG_TARGET_ARCHITECTURE arm) set(VCPKG_CRT_LINKAGE static) set(VCPKG_LIBRARY_LINKAGE static) -set(VCPKG_C_FLAGS "/Qspectre") -set(VCPKG_CXX_FLAGS "/Qspectre") +set(VCPKG_C_FLAGS "/Qspectre /W3") +set(VCPKG_CXX_FLAGS "/Qspectre /W3") set(VCPKG_BUILD_TYPE release) diff --git a/src/VcpkgCustomTriplets/arm-release.cmake b/src/VcpkgCustomTriplets/arm-release.cmake @@ -1,6 +1,6 @@ set(VCPKG_TARGET_ARCHITECTURE arm) set(VCPKG_CRT_LINKAGE dynamic) set(VCPKG_LIBRARY_LINKAGE static) -set(VCPKG_C_FLAGS "/Qspectre") -set(VCPKG_CXX_FLAGS "/Qspectre") +set(VCPKG_C_FLAGS "/Qspectre /W3") +set(VCPKG_CXX_FLAGS "/Qspectre /W3") set(VCPKG_BUILD_TYPE release) diff --git a/src/VcpkgCustomTriplets/arm64-release-static.cmake b/src/VcpkgCustomTriplets/arm64-release-static.cmake @@ -1,6 +1,6 @@ set(VCPKG_TARGET_ARCHITECTURE arm64) set(VCPKG_CRT_LINKAGE static) set(VCPKG_LIBRARY_LINKAGE static) -set(VCPKG_C_FLAGS "/Qspectre") -set(VCPKG_CXX_FLAGS "/Qspectre") +set(VCPKG_C_FLAGS "/Qspectre /W3") +set(VCPKG_CXX_FLAGS "/Qspectre /W3") set(VCPKG_BUILD_TYPE release) diff --git a/src/VcpkgCustomTriplets/arm64-release.cmake b/src/VcpkgCustomTriplets/arm64-release.cmake @@ -1,6 +1,6 @@ set(VCPKG_TARGET_ARCHITECTURE arm64) set(VCPKG_CRT_LINKAGE dynamic) set(VCPKG_LIBRARY_LINKAGE static) -set(VCPKG_C_FLAGS "/Qspectre") -set(VCPKG_CXX_FLAGS "/Qspectre") +set(VCPKG_C_FLAGS "/Qspectre /W3") +set(VCPKG_CXX_FLAGS "/Qspectre /W3") set(VCPKG_BUILD_TYPE release) diff --git a/src/VcpkgCustomTriplets/x64-release-static.cmake b/src/VcpkgCustomTriplets/x64-release-static.cmake @@ -1,6 +1,6 @@ set(VCPKG_TARGET_ARCHITECTURE x64) set(VCPKG_CRT_LINKAGE static) set(VCPKG_LIBRARY_LINKAGE static) -set(VCPKG_C_FLAGS "/Qspectre") -set(VCPKG_CXX_FLAGS "/Qspectre") +set(VCPKG_C_FLAGS "/Qspectre /W3") +set(VCPKG_CXX_FLAGS "/Qspectre /W3") set(VCPKG_BUILD_TYPE release) diff --git a/src/VcpkgCustomTriplets/x64-release.cmake b/src/VcpkgCustomTriplets/x64-release.cmake @@ -1,6 +1,6 @@ set(VCPKG_TARGET_ARCHITECTURE x64) set(VCPKG_CRT_LINKAGE dynamic) set(VCPKG_LIBRARY_LINKAGE static) -set(VCPKG_C_FLAGS "/Qspectre") -set(VCPKG_CXX_FLAGS "/Qspectre") +set(VCPKG_C_FLAGS "/Qspectre /W3") +set(VCPKG_CXX_FLAGS "/Qspectre /W3") set(VCPKG_BUILD_TYPE release) diff --git a/src/VcpkgCustomTriplets/x86-release-static.cmake b/src/VcpkgCustomTriplets/x86-release-static.cmake @@ -1,6 +1,6 @@ set(VCPKG_TARGET_ARCHITECTURE x86) set(VCPKG_CRT_LINKAGE static) set(VCPKG_LIBRARY_LINKAGE static) -set(VCPKG_C_FLAGS "/Qspectre") -set(VCPKG_CXX_FLAGS "/Qspectre") +set(VCPKG_C_FLAGS "/Qspectre /W3") +set(VCPKG_CXX_FLAGS "/Qspectre /W3") set(VCPKG_BUILD_TYPE release) diff --git a/src/VcpkgCustomTriplets/x86-release.cmake b/src/VcpkgCustomTriplets/x86-release.cmake @@ -1,6 +1,6 @@ set(VCPKG_TARGET_ARCHITECTURE x86) set(VCPKG_CRT_LINKAGE dynamic) set(VCPKG_LIBRARY_LINKAGE static) -set(VCPKG_C_FLAGS "/Qspectre") -set(VCPKG_CXX_FLAGS "/Qspectre") +set(VCPKG_C_FLAGS "/Qspectre /W3") +set(VCPKG_CXX_FLAGS "/Qspectre /W3") set(VCPKG_BUILD_TYPE release)