winget-cli

commit a3c686b52e2a8c779f84c66a430272a49dfe51f3
parent a695aa4a0333196be884651d2f30fc514dae0aef
Author: JohnMcPMS <johnmcp@microsoft.com>
Date:   Mon, 26 Feb 2024 17:06:16 -0800

Fix test error and change pipeline to properly report test crash (#4204)

## Change
Fixes a test error that would crash the process due an exception from a
destructor (in test code).

Changes the tasks that run these tests to use `condition:
succeededOrFailed()` rather than `continueOnError: true`, as the latter
results in a warning rather than the formers error.
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4204)
Diffstat:
M
azure-pipelines.yml
 | 
11
++++++++---
M
src/AppInstallerCLITests/TestCommon.cpp
 | 
3
++-

2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -156,7 +156,7 @@ jobs:
       script: |
         $(PsExec.secureFilePath) -accepteula -s -i $(buildOutDir)\AppInstallerCLITests\AppInstallerCLITests.exe -logto $(artifactsDir)\AICLI-Unpackaged-System.log -s -r junit -o $(artifactsDir)\TEST-AppInstallerCLI-Unpackaged-System.xml
       workingDirectory: '$(buildOutDir)\AppInstallerCLITests'
-    continueOnError: true
+    condition: succeededOrFailed()
 
   - task: PowerShell@2
     displayName: Create Package Layout
@@ -164,7 +164,7 @@ jobs:
       filePath: 'src\AppInstallerCLIPackage\Execute-AppxRecipe.ps1'
       arguments: '-AppxRecipePath AppInstallerCLIPackage\bin\$(buildPlatform)\$(buildConfiguration)\AppInstallerCLIPackage.build.appxrecipe -LayoutPath $(packageLayoutDir) -Force -Verbose'
       workingDirectory: 'src'
-    continueOnError: true
+    condition: succeededOrFailed()
 
   - task: PowerShell@2
     displayName: Run Unit Tests Packaged
@@ -172,7 +172,7 @@ jobs:
       filePath: 'src\AppInstallerCLITests\Run-TestsInPackage.ps1'
       arguments: '-Args "~[pips]" -BuildRoot $(buildOutDir) -PackageRoot $(packageLayoutDir) -LogTarget $(artifactsDir)\AICLI-Packaged.log -TestResultsTarget $(artifactsDir)\TEST-AppInstallerCLI-Packaged.xml -ScriptWait'
       workingDirectory: 'src'
-    continueOnError: true
+    condition: succeededOrFailed()
 
   - task: PublishTestResults@2
     displayName: Publish Unit Test Results
@@ -180,6 +180,7 @@ jobs:
       testResultsFormat: 'JUnit'
       testResultsFiles: '$(artifactsDir)\TEST-*.xml'
       failTaskOnFailedTests: true
+    condition: succeededOrFailed()
 
   - task: MSBuild@1
     displayName: Build MSIX Test Installer File
@@ -191,6 +192,7 @@ jobs:
                          /p:AppxBundle=Never
                          /p:UapAppxPackageBuildMode=SideLoadOnly
                          /p:AppxPackageSigningEnabled=false'
+    condition: succeededOrFailed()
 
   - task: PowerShell@2
     displayName: 'Set program files directory'
@@ -202,6 +204,7 @@ jobs:
         } else {
           Write-Host "##vso[task.setvariable variable=platformProgramFiles;]${env:ProgramFiles}"
         }
+    condition: succeededOrFailed()
 
   # Resolves resource strings utilized by InProc E2E tests.
   - task: CopyFiles@2
@@ -210,6 +213,7 @@ jobs:
       SourceFolder: '$(buildOutDir)\AppInstallerCLI'
       TargetFolder:  '$(platformProgramFiles)\dotnet'
       Contents: resources.pri
+    condition: succeededOrFailed()
 
   # Winmd accessed by test runner process (dotnet.exe)
   - task: CopyFiles@2
@@ -218,6 +222,7 @@ jobs:
       SourceFolder: '$(buildOutDir)\Microsoft.Management.Deployment'
       TargetFolder: '$(platformProgramFiles)\dotnet'
       Contents: Microsoft.Management.Deployment.winmd
+    condition: succeededOrFailed()
 
   - template: templates/e2e-setup.yml
     parameters:
diff --git a/src/AppInstallerCLITests/TestCommon.cpp b/src/AppInstallerCLITests/TestCommon.cpp
@@ -85,7 +85,7 @@ namespace TestCommon
         }
     }
 
-    TempFile::~TempFile()
+    TempFile::~TempFile() try
     {
         switch (s_TempFileDestructorBehavior)
         {
@@ -99,6 +99,7 @@ namespace TestCommon
             break;
         }
     }
+    CATCH_LOG_RETURN()
 
     void TempFile::Rename(const std::filesystem::path& newFilePath)
     {