commit c2781b03d820e2c84e6d489468e6a9886ada42fd
parent ea9853660c1fafbcd42f4d5f0118ed82be6f8eac
Author: yao-msft <50888816+yao-msft@users.noreply.github.com>
Date: Tue, 30 Apr 2024 18:39:58 -0700
Make SecurityContext field name camelCase (#4433)
To be consistent with other field names in configuration file. We may
want to improve to be case insensitive of all field names in the future.
Diffstat:
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/AppInstallerCLICore/ConfigurationDynamicRuntimeFactory.cpp b/src/AppInstallerCLICore/ConfigurationDynamicRuntimeFactory.cpp
@@ -99,7 +99,7 @@ namespace AppInstaller::CLI::ConfigurationRemoting
// Support for 0.2 schema via metadata value
// TODO: Support case insensitive lookup by iteration
auto unitMetadata = unit.Metadata();
- auto securityContext = unitMetadata.TryLookup(L"SecurityContext");
+ auto securityContext = unitMetadata.TryLookup(L"securityContext");
if (securityContext)
{
auto securityContextProperty = securityContext.try_as<IPropertyValue>();
diff --git a/src/Microsoft.Management.Configuration.UnitTests/Tests/OpenConfigurationSetTests.cs b/src/Microsoft.Management.Configuration.UnitTests/Tests/OpenConfigurationSetTests.cs
@@ -487,7 +487,7 @@ properties:
directives:
description: FakeDescription
allowPrerelease: true
- SecurityContext: elevated
+ securityContext: elevated
settings:
TestString: Hello
TestBool: false
@@ -501,7 +501,7 @@ properties:
- dependency3
directives:
description: FakeDescription2
- SecurityContext: elevated
+ securityContext: elevated
settings:
TestString: Bye
TestBool: true
@@ -529,14 +529,14 @@ properties:
Assert.Equal("FakeModule", set.Units[0].Type);
Assert.Equal(ConfigurationUnitIntent.Assert, set.Units[0].Intent);
Assert.Equal("TestId", set.Units[0].Identifier);
- this.VerifyValueSet(set.Units[0].Metadata, new ("description", "FakeDescription"), new ("allowPrerelease", true), new ("SecurityContext", "elevated"));
+ this.VerifyValueSet(set.Units[0].Metadata, new ("description", "FakeDescription"), new ("allowPrerelease", true), new ("securityContext", "elevated"));
this.VerifyValueSet(set.Units[0].Settings, new ("TestString", "Hello"), new ("TestBool", false), new ("TestInt", 1234));
Assert.Equal("FakeModule2", set.Units[1].Type);
Assert.Equal(ConfigurationUnitIntent.Apply, set.Units[1].Intent);
Assert.Equal("TestId2", set.Units[1].Identifier);
this.VerifyStringArray(set.Units[1].Dependencies, "TestId", "dependency2", "dependency3");
- this.VerifyValueSet(set.Units[1].Metadata, new ("description", "FakeDescription2"), new ("SecurityContext", "elevated"));
+ this.VerifyValueSet(set.Units[1].Metadata, new ("description", "FakeDescription2"), new ("securityContext", "elevated"));
ValueSet mapping = new ValueSet();
mapping.Add("Key", "TestValue");