winget-cli

commit ff65c79dab1bcbd7329e9507814894142e67c406
parent 8ae9f00e3e03553784942cd04a3dba0b47e6e318
Author: mapill-msft <58245272+mapill-msft@users.noreply.github.com>
Date:   Tue, 18 Feb 2020 13:43:05 -0800

Promoting PackageManager client events to critical telemetry similar to other OOB products, such as emulator, as we discussed in scrum. (#37)


Diffstat:
M
src/AppInstallerCommonCore/AppInstallerTelemetry.cpp
 | 
14
+++++++-------
M
src/AppInstallerCommonCore/Telemetry/TraceLogging.cpp
 | 
2
+-

2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/AppInstallerCommonCore/AppInstallerTelemetry.cpp b/src/AppInstallerCommonCore/AppInstallerTelemetry.cpp
@@ -79,7 +79,7 @@ namespace AppInstaller::Logging
                 TraceLoggingString(failure.pszFile, "file"),
                 TraceLoggingUInt32(failure.uLineNumber, "line"),
                 TelemetryPrivacyDataTag(PDT_ProductAndServicePerformance),
-                TraceLoggingKeyword(MICROSOFT_KEYWORD_MEASURES));
+                TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA));
         }
 
         // Also send failure to the log
@@ -102,8 +102,8 @@ namespace AppInstaller::Logging
                 nullptr,
                 TraceLoggingCountedString(version.c_str(), static_cast<ULONG>(version.size()), "version"),
                 TraceLoggingWideString(GetCommandLineW(), "commandlineargs"),
-                TelemetryPrivacyDataTag(PDT_ProductAndServicePerformance),
-                TraceLoggingKeyword(MICROSOFT_KEYWORD_MEASURES));
+                TelemetryPrivacyDataTag(PDT_ProductAndServicePerformance|PDT_ProductAndServiceUsage),
+                TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA));
         }
 
         AICLI_LOG(CLI, Info, << "AppInstallerCLI, version [" << version << "], activity [" << *GetActivityId() << ']');
@@ -119,7 +119,7 @@ namespace AppInstaller::Logging
                 nullptr,
                 TraceLoggingCountedString(commandName.data(), static_cast<ULONG>(commandName.size()), "Command"),
                 TelemetryPrivacyDataTag(PDT_ProductAndServicePerformance),
-                TraceLoggingKeyword(MICROSOFT_KEYWORD_MEASURES));
+                TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA));
         }
 
         AICLI_LOG(CLI, Info, << "Leaf command to execute: " << commandName);
@@ -135,7 +135,7 @@ namespace AppInstaller::Logging
                 nullptr,
                 TraceLoggingCountedString(commandName.data(), static_cast<ULONG>(commandName.size()), "Command"),
                 TelemetryPrivacyDataTag(PDT_ProductAndServicePerformance),
-                TraceLoggingKeyword(MICROSOFT_KEYWORD_MEASURES));
+                TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA));
         }
 
         AICLI_LOG(CLI, Info, << "Leaf command succeeded: " << commandName);
@@ -151,8 +151,8 @@ namespace AppInstaller::Logging
                 nullptr,
                 TraceLoggingCountedString(name.c_str(), static_cast<ULONG>(name.size()),"Name"),
                 TraceLoggingCountedString(version.c_str(), static_cast<ULONG>(version.size()), "Version"),
-                TelemetryPrivacyDataTag(PDT_ProductAndServicePerformance),
-                TraceLoggingKeyword(MICROSOFT_KEYWORD_MEASURES));
+                TelemetryPrivacyDataTag(PDT_ProductAndServicePerformance|PDT_ProductAndServiceUsage),
+                TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA));
         }
 
         AICLI_LOG(CLI, Info, << "AppInstallerCLI, Name [" << name << "], Version [" << version << ']');
diff --git a/src/AppInstallerCommonCore/Telemetry/TraceLogging.cpp b/src/AppInstallerCommonCore/Telemetry/TraceLogging.cpp
@@ -46,7 +46,7 @@ void RegisterTraceLogging()
             nullptr,
             TraceLoggingHResult(hr),
             TelemetryPrivacyDataTag(PDT_ProductAndServicePerformance),
-            TraceLoggingKeyword(MICROSOFT_KEYWORD_MEASURES));
+            TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA));
 
         g_TelemetryProviderActivityId = GUID_NULL;
     };